Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicate action registrations #186582

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Avoid duplicate action registrations #186582

merged 3 commits into from
Jun 29, 2023

Conversation

joyceerhl
Copy link
Contributor

@joyceerhl joyceerhl enabled auto-merge (squash) June 28, 2023 23:50
@joyceerhl joyceerhl self-assigned this Jun 28, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the June 2023 milestone Jun 28, 2023
TylerLeonhardt
TylerLeonhardt previously approved these changes Jun 28, 2023
View reviewed changes
rzhao271
rzhao271 requested changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@rzhao271 rzhao271 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, where's _disposables instantiated after this change?
Edit: nvm found it in registerActions(). The other feedback comment above still applies, though.

rzhao271
rzhao271 previously approved these changes Jun 29, 2023
View reviewed changes
@joyceerhl joyceerhl merged commit ed9fc30 into main Jun 29, 2023
6 checks passed
@joyceerhl joyceerhl deleted the dev/joyceerhl/foolish-lark branch June 29, 2023 14:53
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rzhao271 rzhao271 rzhao271 approved these changes

@TylerLeonhardt TylerLeonhardt TylerLeonhardt left review comments

Assignees

@joyceerhl joyceerhl

Labels
None yet
Projects
None yet
Milestone
June 2023
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joyceerhl @TylerLeonhardt @rzhao271 @VSCodeTriageBot