Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git (SCM) issues in latest insiders #18665

Closed
eamodio opened this issue Jan 17, 2017 · 3 comments
Closed

Git (SCM) issues in latest insiders #18665

eamodio opened this issue Jan 17, 2017 · 3 comments
Assignees
Labels
git GIT issues

Comments

@eamodio
Copy link
Contributor

eamodio commented Jan 17, 2017

  • VSCode Version: 1.9.0-insider f67f87c
  • OS Version: macOS Sierra 10.12.2

The new SCM changes seem to have lost a bunch of functionality as well as caused some bugs.

Bugs:

  • The SCM icon (hopefully it is temporary) doesn't show any badge (count) until you open it.
  • Can't open a file diff (from the SCM pane) with GitLens installed -- throws errors. I will take a look into this, but I mention it mainly because it could break a bunch of users until I get an update out. -- EDIT: I've pushed a new version of GitLens that fixes the issue (I was using a DocumentScheme of git it is now gitlens-git)

Missing features:

  • Commit button is missing
  • Many missing Git commands from the content menu (pull, push, etc)
  • File diff is missing toggle back (and forth) to the file
  • Staging lines -- was an AWESOME feature (would have been nice to even be more prominent)
  • Commit message length notification
@DuncanBeard
Copy link

Thanks for updating GitLens - fixed the errors for me.

@dbaeumer dbaeumer added the git GIT issues label Jan 18, 2017
@joaomoreno
Copy link
Member

Much thanks for the summary, but it's always better to file each issue independently. 👍

Some of these are already fixed, some are dupes, others tracked here: #18615.

@eamodio
Copy link
Contributor Author

eamodio commented Jan 18, 2017

@joaomoreno will do next time -- just didn't want to create a ton of noise. Thanks!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
git GIT issues
Projects
None yet
Development

No branches or pull requests

4 participants