Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use workspace ID in revive pty id map #186947

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Use workspace ID in revive pty id map #186947

merged 1 commit into from
Jul 3, 2023

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 3, 2023

Fixes #133542

Before:

2023-07-03 13:01:56.461 [info] Expanding terminal instance, old id 1 -> new id 3
2023-07-03 13:01:56.461 [info] Expanding terminal instance, old id 2 -> new id 4
2023-07-03 13:01:57.086 [info] Expanding terminal instance, old id 1 -> new id undefined
2023-07-03 13:01:57.086 [info] Expanding terminal instance, old id 2 -> new id undefined

After:

2023-07-03 13:48:49.293 [info] Expanding terminal instance, old id a1b26a62c0dc8506dbab12536639ec57-3 -> new id 1
2023-07-03 13:48:49.294 [info] Expanding terminal instance, old id a1b26a62c0dc8506dbab12536639ec57-4 -> new id 2
2023-07-03 13:48:49.935 [info] Expanding terminal instance, old id 1b927216d3a88da4037d872d0731b799-1 -> new id 3
2023-07-03 13:48:49.935 [info] Expanding terminal instance, old id 1b927216d3a88da4037d872d0731b799-2 -> new id 4

@Tyriar Tyriar added this to the July 2023 milestone Jul 3, 2023
@Tyriar Tyriar requested a review from meganrogge July 3, 2023 20:56
@Tyriar Tyriar self-assigned this Jul 3, 2023
@Tyriar Tyriar merged commit d4971c3 into main Jul 3, 2023
7 checks passed
@Tyriar Tyriar deleted the tyriar/133542_5 branch July 3, 2023 21:15
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reattached to the wrong terminal
2 participants