Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show busy indicator in remote menu when initializing. #187018

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

bhavyaus
Copy link
Contributor

@bhavyaus bhavyaus commented Jul 5, 2023

Fixes:
#186278

Changing up the remote indicator experience to be always enabled from startup (with #184845 we have added the ability to install remote extensions). Since initialization may not have completed yet, we show a busy indicator if quick pick is opened.

See experience below of opening remote indicator on startup:
Recording 2023-07-04 at 18 00 41

@bhavyaus bhavyaus force-pushed the dev/bhavyau/remote-indicator branch from 7fb842f to 09393d5 Compare July 5, 2023 04:32
Copy link
Contributor

@joyceerhl joyceerhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for the quick pick items taking so long to be computed? IIRC it's mostly the extension gallery service taking a while to return extensions, but is there anything we can do to speed that up?

@bhavyaus
Copy link
Contributor Author

bhavyaus commented Jul 5, 2023

What's the reason for the quick pick items taking so long to be computed? IIRC it's mostly the extension gallery service taking a while to return extensions, but is there anything we can do to speed that up?

Thats pretty much it - the extension gallery service checking to see if the extension is installable for the platform. This is one-time startup only initialization and not much else we can do. I'd also throttled the CPU during screen capture.

@bhavyaus bhavyaus merged commit 99494a7 into main Jul 5, 2023
6 checks passed
@bhavyaus bhavyaus deleted the dev/bhavyau/remote-indicator branch July 5, 2023 23:14
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants