Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

just use the extension property to know if an editor needs to be registered #187070

Merged
merged 3 commits into from
Jul 6, 2023
Merged

just use the extension property to know if an editor needs to be registered #187070

merged 3 commits into from
Jul 6, 2023

Conversation

amunger
Copy link
Contributor

@amunger amunger commented Jul 5, 2023 •
edited

@amunger amunger requested a review from rebornix July 5, 2023 17:52
@amunger amunger marked this pull request as ready for review July 5, 2023 17:52
@VSCodeTriageBot VSCodeTriageBot added this to the July 2023 milestone Jul 5, 2023
@amunger amunger mentioned this pull request Jul 5, 2023
Closed
rebornix
rebornix approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked that if Live Share registers a serializer at runtime, it will register with extension data so this is a safe fix. Thanks!

@amunger amunger merged commit 0daeaf5 into main Jul 6, 2023
6 checks passed
@amunger amunger deleted the aamunger/notebookInfoRegistration2 branch July 6, 2023 16:59
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rebornix rebornix rebornix approved these changes

Assignees

@amunger amunger

Labels
None yet
Projects
None yet
Milestone
July 2023
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amunger @rebornix @VSCodeTriageBot