Also check for secret storage provider before using old API #187105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a nice migration path for web environments: 1. Embedder implements a secret storage provider in addition to the credentials provider they already have 2. Wait a release or 2 3. Remove the credentials provider from the embedder Once all known embedders do number 1, we can delete the `_oldMainThreadSecretState` entirely.
DonJayamanne
approved these changes
Jul 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a nice migration path for web environments:
Once all known embedders do number 1, we can delete the
_oldMainThreadSecretStateentirely. Once all known embedders do 1-3, then web environments won't block the removal of the CredentialsService.