Add IPtyHostService #187177
Merged
Add IPtyHostService #187177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a new service which extends IPtyService and provides additional methods on the process that manages the connection to the pty host: - IPtyService: Talk to the pty host, this may be direct via a message port of via the main/server procs. - IPtyHostService: Talk to the pty host management interfaces on the main/server procs. These are no longer available as optional methods on IPtyService to be clear about where they happen (eg. getProfiles). Fixes #186935
meganrogge
reviewed
Jul 6, 2023
| case '$clearBuffer': return this._ptyService.clearBuffer.apply(this._ptyService, args); | ||
| case '$getInitialCwd': return this._ptyService.getInitialCwd.apply(this._ptyService, args); | ||
| case '$getCwd': return this._ptyService.getCwd.apply(this._ptyService, args); | ||
| case '$start': return this._ptyHostService.start.apply(this._ptyHostService, args); |
There was a problem hiding this comment.
I still find this syntax a bit confusing - passing in the ptyHostService to it's function application... 🤔
There was a problem hiding this comment.
That's binding the this variable inside the function, which you need to do when you use apply, otherwise it would be undefined.
meganrogge
approved these changes
Jul 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new service which extends IPtyService and provides additional methods on the process that manages the connection to the pty host:
Fixes #186935