Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log latency stats and remove old unused latency mechanism #187281

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 7, 2023

Fixes #187274

This change measures latency in an idle callback after each terminal process is created.

Example logs:

2023-07-07 08:38:15.407 [info] Latency measurements for test+test backend
window<->ptyhostservice<->ptyhost: 16.70ms
ptyhostservice<->ptyhost: 0.75ms []

2023-07-07 08:38:44.243 [info] Latency measurements for local backend
window<->ptyhost (message port): 0.40ms
window<->ptyhostservice<->ptyhost: 1.30ms
ptyhostservice<->ptyhost: 0.45ms []

@Tyriar Tyriar added this to the July 2023 milestone Jul 7, 2023
@Tyriar Tyriar requested a review from meganrogge July 7, 2023 15:35
@Tyriar Tyriar self-assigned this Jul 7, 2023
@Tyriar Tyriar enabled auto-merge July 7, 2023 15:39
sw.stop();
return [
{
label: 'window<->ptyhostservice<->ptyhost',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this label include remote?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tyriar Tyriar merged commit 968379f into main Jul 7, 2023
6 checks passed
@Tyriar Tyriar deleted the tyriar/187274 branch July 7, 2023 15:54
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Measure and log pty host latency
2 participants