Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify screencast keyboard options #187469

Merged
merged 1 commit into from
Jul 10, 2023
Merged

simplify screencast keyboard options #187469

merged 1 commit into from
Jul 10, 2023

Conversation

joaomoreno
Copy link
Member

fixes #179541

@joaomoreno joaomoreno self-assigned this Jul 10, 2023
@joaomoreno joaomoreno enabled auto-merge (squash) July 10, 2023 13:01
@VSCodeTriageBot VSCodeTriageBot added this to the July 2023 milestone Jul 10, 2023
type: 'boolean',
description: localize('screencastMode.hideSingleEditorCursorMoves', "Hide the single editor cursor move commands in screencast mode."),
default: false
'screencastMode.keyboardOptions': {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these settings need deprecation that points at the new ones?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a developer action, screencast mode, I didn't give too much thought on deprecation. Let me know if you feel strongly about it.

@joaomoreno joaomoreno merged commit 060dfba into main Jul 10, 2023
7 checks passed
@joaomoreno joaomoreno deleted the joao/lime-cobra branch July 10, 2023 13:15
@SpencerRauch
Copy link

Screencast mostly still broken. No way to just show commands and their key strokes, only able to show all key strokes.
options
These options result in no display of anything in screencast mode. This mode used to be super useful for demonstrations, now has very little utility.

Only the show raw keys is currently working.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screencast mode regression - always shows all keystrokes
4 participants