Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing extension to specify the position where inline chat should appear #187478

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

aiday-mar
Copy link
Contributor

@aiday-mar aiday-mar commented Jul 10, 2023

Part of the fix for https://github.com/microsoft/vscode-copilot/issues/447

Second part of the fix: https://github.com/microsoft/vscode-copilot/pull/659

This PR adds code in order to allow extension calls to vscode.editorChat.start to specify the position at which the inline chat should appear.

@aiday-mar aiday-mar self-assigned this Jul 10, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the July 2023 milestone Jul 10, 2023
@aiday-mar aiday-mar marked this pull request as draft July 10, 2023 15:17
@aiday-mar aiday-mar marked this pull request as ready for review July 10, 2023 15:40
@aiday-mar aiday-mar enabled auto-merge July 10, 2023 15:40
@jrieken jrieken self-requested a review July 10, 2023 15:54
@aiday-mar aiday-mar merged commit 1c62250 into main Jul 10, 2023
6 checks passed
@aiday-mar aiday-mar deleted the aiday/positionInlineChatFromExtension branch July 10, 2023 17:10
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants