include error message when save fails #187479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
approved these changes
Jul 10, 2023
Tyriar
reviewed
Jul 10, 2023
| @@ -210,7 +210,7 @@ export class ConfigurationEditing { | |||
| if ((<FileOperationError>error).fileOperationResult === FileOperationResult.FILE_MODIFIED_SINCE) { | |||
| throw this.toConfigurationEditingError(ConfigurationEditingErrorCode.ERROR_CONFIGURATION_FILE_MODIFIED_SINCE, operation.target, operation); | |||
| } | |||
| throw this.toConfigurationEditingError(ConfigurationEditingErrorCode.ERROR_INTERNAL, operation.target, operation); | |||
| throw new ConfigurationEditingError(nls.localize('fsError', "Error while writing to {0}. {1}", this.stringifyTarget(operation.target), error.message), ConfigurationEditingErrorCode.ERROR_INTERNAL); | |||
There was a problem hiding this comment.
Just making sure this isn't sent to telemetry, if it is we would get one per language per operation target per error message
There was a problem hiding this comment.
if it is we would get one per language per operation target per error message
Not sure if I understood this. Why is it one per... ?
There was a problem hiding this comment.
The string is reported uniquely, so it's the set of combinations of localized message, operation.target and error.message
There was a problem hiding this comment.
Ah got it. This caller of this can be API or user. Since user can see this error, it is translated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include error message when save fails