build: check for cargo.lock changes in pr too #187481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think renaming the pipeline confused Github's policy matching logic. I'll keep the old name for now to avoid breaking incoming PRs |
Tyriar
previously requested changes
Jul 10, 2023
| if: ${{ steps.control.outputs.should_run == 'true' }} | ||
| run: | | ||
| cat $HOME/files.json | jq -e 'any(test("yarn\\.lock$")) | not' \ |
There was a problem hiding this comment.
Should we add package-lock.json while we're at it?
There was a problem hiding this comment.
We don't have any package-lock.json's in the vscode repo at the moment
TylerLeonhardt
approved these changes
Jul 10, 2023
connor4312
dismissed
Tyriar’s stale review
let me know if you think a followup pr is warranted
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.