Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky Scroll setState optimization #187567

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Conversation

aiday-mar
Copy link
Contributor

Fixes #185884

@aiday-mar aiday-mar self-assigned this Jul 11, 2023
@aiday-mar aiday-mar requested a review from jrieken July 11, 2023 10:59
@aiday-mar aiday-mar marked this pull request as ready for review July 11, 2023 10:59
@VSCodeTriageBot VSCodeTriageBot added this to the July 2023 milestone Jul 11, 2023
jrieken
jrieken previously approved these changes Jul 11, 2023
@aiday-mar aiday-mar merged commit d9d32c0 into main Jul 11, 2023
6 checks passed
@aiday-mar aiday-mar deleted the aiday/stickyScrollSmallOptimization branch July 11, 2023 12:55
Ulop pushed a commit to Megaputer/vscode that referenced this pull request Jul 11, 2023
…SmallOptimization

Sticky Scroll setState optimization
@aiday-mar
Copy link
Contributor Author

This PR caused a regression, which lead to the following issues: #187637 as well as #187918. This PR will be reverted.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance Improvement Suggestion: Only Rerender Sticky Scroll When State Is Different
3 participants