Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting minimum dimensions on the resizable hover when color picker is embedded #187592

Merged
merged 5 commits into from
Jul 26, 2023
Merged

Setting minimum dimensions on the resizable hover when color picker is embedded #187592

merged 5 commits into from
Jul 26, 2023

Conversation

aiday-mar
Copy link
Contributor

@aiday-mar aiday-mar commented Jul 11, 2023 •
edited

Fixes #187581

@aiday-mar aiday-mar self-assigned this Jul 11, 2023
@aiday-mar aiday-mar requested a review from jrieken July 12, 2023 08:04
@aiday-mar aiday-mar marked this pull request as ready for review July 12, 2023 08:04
@VSCodeTriageBot VSCodeTriageBot added this to the July 2023 milestone Jul 12, 2023
@aiday-mar aiday-mar marked this pull request as draft July 24, 2023 11:41
@aiday-mar aiday-mar marked this pull request as ready for review July 24, 2023 11:47
@aiday-mar aiday-mar closed this Jul 24, 2023
@aiday-mar aiday-mar reopened this Jul 24, 2023
@alexdima alexdima self-requested a review July 24, 2023 15:37
alexdima
alexdima requested changes Jul 24, 2023
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The opacitiy / hue sliders disappear for me when I resize the hover to make it very small:

image

@aiday-mar
Copy link
Contributor Author

Hi @alexdima, yes indeed. I'll instead set a minimum size on the resizable hover when a color picker is embedded in the content widget.

@aiday-mar aiday-mar requested a review from alexdima July 25, 2023 12:05
@aiday-mar aiday-mar changed the title Set minimum width on the color presentation in the color picker Setting minimum dimensions on the resizable hover when color picker is embedded Jul 25, 2023
@aiday-mar aiday-mar modified the milestones: July 2023, August 2023 Jul 25, 2023
@alexdima alexdima modified the milestones: August 2023, July 2023 Jul 26, 2023
@alexdima alexdima removed the request for review from jrieken July 26, 2023 07:19
alexdima
alexdima approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@alexdima alexdima enabled auto-merge (squash) July 26, 2023 07:20
@alexdima alexdima merged commit cdf84c6 into main Jul 26, 2023
5 of 6 checks passed
@alexdima alexdima deleted the aiday/resizeColorPickerPresentation branch July 26, 2023 07:27
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexdima alexdima alexdima approved these changes

Assignees

@aiday-mar aiday-mar

Labels
None yet
Projects
None yet
Milestone
July 2023
Development

Successfully merging this pull request may close these issues.

Color Picker Widget: unexpected sizing of original color
3 participants
@aiday-mar @alexdima @VSCodeTriageBot