Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide symbol info to screen reader users in documentSymbolsTree, go to symbol quickpick #187941

Merged
merged 12 commits into from
Jul 15, 2023
Merged

provide symbol info to screen reader users in documentSymbolsTree, go to symbol quickpick #187941

merged 12 commits into from
Jul 15, 2023

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Jul 14, 2023 •
edited

part of #163506

@meganrogge meganrogge added this to the July 2023 milestone Jul 14, 2023
@meganrogge meganrogge self-assigned this Jul 14, 2023
@meganrogge meganrogge marked this pull request as draft July 14, 2023 17:08
auto-merge was automatically disabled July 14, 2023 17:08

Pull request was converted to draft

@meganrogge meganrogge marked this pull request as ready for review July 14, 2023 17:13
TylerLeonhardt
TylerLeonhardt previously approved these changes Jul 14, 2023
View reviewed changes
jrieken
jrieken requested changes Jul 14, 2023
View reviewed changes
src/vs/editor/common/languages.ts Outdated Show resolved Hide resolved
@meganrogge meganrogge requested a review from jrieken July 14, 2023 17:51
@meganrogge meganrogge changed the title provide symbol info to screen reader users in documentSymbolsTree provide symbol info to screen reader users in documentSymbolsTree, go to symbol quickpick Jul 14, 2023
jrieken
jrieken previously requested changes Jul 14, 2023
View reviewed changes
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still uses icon identifiers as UI strings

meganrogge
meganrogge commented Jul 14, 2023
View reviewed changes
src/vs/monaco.d.ts Outdated Show resolved Hide resolved
@meganrogge meganrogge requested a review from jrieken July 14, 2023 19:10
roblourens
roblourens previously approved these changes Jul 15, 2023
View reviewed changes
@meganrogge
Copy link
Contributor Author

note that now the go to symbol quick pick aria label is correct, but the quick pick element is still getting read by the screen reader instead of that, so will need to investigate further cc @TylerLeonhardt

@meganrogge meganrogge merged commit 18136ed into main Jul 15, 2023
6 checks passed
@meganrogge meganrogge deleted the merogge/symbol-icon branch July 15, 2023 01:58
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

@TylerLeonhardt TylerLeonhardt TylerLeonhardt left review comments

@jrieken jrieken Awaiting requested review from jrieken

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
July 2023
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@meganrogge @roblourens @jrieken @TylerLeonhardt