Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow slash commands to opt into auto-executing #188097

Merged
merged 7 commits into from
Jul 18, 2023

Conversation

joyceerhl
Copy link
Contributor

No description provided.

@joyceerhl joyceerhl enabled auto-merge (squash) July 17, 2023 18:34
@joyceerhl joyceerhl self-assigned this Jul 17, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the July 2023 milestone Jul 17, 2023
@joyceerhl joyceerhl changed the title Allow slash commands to opt into auto-executing Allow panel chat slash commands to opt into auto-executing Jul 17, 2023
@joyceerhl joyceerhl changed the title Allow panel chat slash commands to opt into auto-executing Allow slash commands to opt into auto-executing Jul 17, 2023
@joyceerhl joyceerhl requested a review from jrieken July 17, 2023 21:54
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe a simpler and more correct way would via CompletionItem#command, see #188097 (comment)

@joyceerhl joyceerhl merged commit 1826243 into microsoft:main Jul 18, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants