testing: finalize testInvalidateResults #188180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also sends the tests as a bulk to the renderer, and implements a prefix tree for doing invalidation checks (which I plan to adopt elsewhere later on, perhaps in debt week.)
hediet
approved these changes
Jul 18, 2023
Comment on lines
+16
to
+18
| insert(key: Iterable<string>, value: V): void { | ||
| let node = this.root; | ||
| for (const part of key) { |
There was a problem hiding this comment.
path might be a better name.
Suggested change
| insert(key: Iterable<string>, value: V): void { | |
| let node = this.root; | |
| for (const part of key) { | |
| insert(path: Iterable<string>, value: V): void { | |
| let node = this.root; | |
| for (const part of path) { |
Comment on lines
+37
to
+39
| find(key: Iterable<string>): V | undefined { | ||
| let node = this.root; | ||
| for (const segment of key) { |
There was a problem hiding this comment.
Suggested change
| find(key: Iterable<string>): V | undefined { | |
| let node = this.root; | |
| for (const segment of key) { | |
| find(path: Iterable<string>): V | undefined { | |
| let node = this.root; | |
| for (const segment of path) { |
| * A simple prefix tree implementation where a value is stored based on | ||
| * well-defined prefix segments. | ||
| */ | ||
| export class WellDefinedPrefixTree<V> { |
There was a problem hiding this comment.
Maybe RadixTrie is a better name? https://en.wikipedia.org/wiki/Radix_tree
| } | ||
|
|
||
| /** Gets whether the tree has the key, or a parent of the key, already inserted. */ | ||
| hasKeyOrParent(key: Iterable<string>): boolean { |
There was a problem hiding this comment.
Maybe
Suggested change
| hasKeyOrParent(key: Iterable<string>): boolean { | |
| containsPrefixOfPath(path: Iterable<string>): boolean { |
Might be easier to understand?
| } | ||
|
|
||
| /** Gets whether the tree has the given key or any children. */ | ||
| hasKeyOrChildren(key: Iterable<string>): boolean { |
There was a problem hiding this comment.
Maybe
Suggested change
| hasKeyOrChildren(key: Iterable<string>): boolean { | |
| containsExtensionOfPath(path: Iterable<string>): boolean { |
?
(Assuming the empty extension is an extension)
| tree.insert(key, 42); | ||
|
|
||
| assert.strictEqual(tree.hasKeyOrParent(['foo', 'bar', 'baz']), true); | ||
| assert.strictEqual(tree.hasKeyOrParent(['foo', 'bar']), true); |
There was a problem hiding this comment.
A test for tree.hasKeyOrParent(['foo', 'baz']) might be interesting
|
Left some comments, but feel free to ignore |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also sends the tests as a bulk to the renderer, and implements a
prefix tree for doing invalidation checks (which I plan to adopt
elsewhere later on, perhaps in debt week.)