Only render notebook container if visible #188226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebornix
approved these changes
Oct 5, 2023
connor4312
approved these changes
Oct 5, 2023
connor4312
approved these changes
Oct 5, 2023
Alex0007
pushed a commit
to Alex0007/vscode
that referenced
this pull request
Oct 26, 2023
Co-authored-by: Peng Lyu <penn.lv@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #179671
The bug was introduced by #175550 and is caused by executing
layoutContainerOverShadowElementwhen the notebooks is overlayed by the terminal and therefor should not be visible. This causes the the container to be rendered with an height, e.g.:While I am not 100% familiar with the interplay of all components my best guess was to assert the
_isVisiblestate to decide whether to run that method. It definitely resolves the bug but could have implications for other workflows.