put cell output content into accessibility view #188310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
reviewed
Jul 20, 2023
| ariaLabel: nls.localize('NotebookCellOutputAccessibleView', "Notebook Cell Output Accessible View"), | ||
| language: 'plaintext', | ||
| type: AccessibleViewType.View | ||
| } |
There was a problem hiding this comment.
did you want to add the next and previous functions here as well? if you pull main, you can @amunger
There was a problem hiding this comment.
I don't see an easy way to synchronously focus on another cell, so I'll leave that out for now.
meganrogge
previously approved these changes
Jul 20, 2023
amunger
force-pushed
the
aamunger/notebookOutputView
branch
from
6bc55f3
to
587ce36
Compare
meganrogge
approved these changes
Jul 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #183208