Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wording, allow undefined to be returned #188405

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Jul 20, 2023

this is used by several components - we don't want "command" to be used for all of them

@meganrogge meganrogge self-assigned this Jul 20, 2023
@meganrogge meganrogge added this to the July 2023 milestone Jul 20, 2023
mjbvz
mjbvz previously requested changes Jul 20, 2023
Copy link
Contributor

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some other changes get included in this PR besides the wording change?

@meganrogge
Copy link
Contributor Author

yes, intentionally so @mjbvz

@meganrogge meganrogge changed the title fix wording fix wording, allow undefined to be returned Jul 20, 2023
@meganrogge meganrogge requested a review from mjbvz July 20, 2023 19:03
@meganrogge meganrogge merged commit 6e19e63 into main Jul 20, 2023
6 checks passed
@meganrogge meganrogge deleted the merogge/fix-wording branch July 20, 2023 19:50
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants