Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the .. argument for git log #188500

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Enable the .. argument for git log #188500

merged 3 commits into from
Sep 4, 2023

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Jul 21, 2023

This will return the commits that the toRef has but the fromRef does not.

This will return the commits that the `toRef` has but the `fromRef` does not.
@alexr00 alexr00 marked this pull request as ready for review August 23, 2023 17:36
@lszomoru
Copy link
Member

Thank you very much for submitting the pull request. These changes address the .. special notation but will not work with the ... notation. I think that we should do something that is more generic to make sure that both notations are handled. Maybe something like this:

readonly range?: string;
if (options?.range) {
	args.push(options.range);
}

Copy link
Member

@lszomoru lszomoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please feel free to ping me if you would like to discuss this more. Thanks!

@alexr00 alexr00 requested a review from lszomoru August 28, 2023 15:57
@alexr00
Copy link
Member Author

alexr00 commented Aug 28, 2023

Using a range instead makes sense to me. I have updated the PR with this change.

@alexr00 alexr00 enabled auto-merge (squash) August 28, 2023 19:22
@alexr00 alexr00 disabled auto-merge August 28, 2023 19:22
@alexr00 alexr00 enabled auto-merge (squash) August 28, 2023 19:23
@alexr00 alexr00 disabled auto-merge August 28, 2023 19:24
@alexr00 alexr00 enabled auto-merge (squash) August 28, 2023 19:24
@alexr00 alexr00 disabled auto-merge August 28, 2023 19:37
@alexr00 alexr00 enabled auto-merge (squash) August 28, 2023 19:37
@alexr00 alexr00 disabled auto-merge August 28, 2023 19:37
@alexr00 alexr00 enabled auto-merge (squash) August 28, 2023 19:37
@alexr00 alexr00 disabled auto-merge August 28, 2023 19:37
@alexr00 alexr00 enabled auto-merge (squash) August 28, 2023 19:37
@alexr00 alexr00 disabled auto-merge August 28, 2023 19:53
@alexr00 alexr00 enabled auto-merge (squash) August 28, 2023 19:56
@alexr00 alexr00 disabled auto-merge August 28, 2023 19:56
@alexr00 alexr00 enabled auto-merge (squash) August 28, 2023 19:56
@alexr00 alexr00 disabled auto-merge August 28, 2023 19:56
@alexr00 alexr00 enabled auto-merge (squash) August 28, 2023 19:57
@alexr00 alexr00 disabled auto-merge August 28, 2023 19:57
@alexr00 alexr00 enabled auto-merge (squash) August 28, 2023 20:07
@alexr00 alexr00 disabled auto-merge August 28, 2023 20:07
@alexr00 alexr00 enabled auto-merge (squash) August 28, 2023 20:08
@alexr00 alexr00 disabled auto-merge August 28, 2023 20:08
@alexr00 alexr00 enabled auto-merge (rebase) August 28, 2023 20:08
@alexr00 alexr00 disabled auto-merge August 28, 2023 20:08
@alexr00 alexr00 enabled auto-merge (squash) August 28, 2023 20:08
@alexr00 alexr00 disabled auto-merge August 28, 2023 20:08
@alexr00 alexr00 enabled auto-merge (squash) August 28, 2023 20:08
@alexr00 alexr00 disabled auto-merge August 28, 2023 20:11
@alexr00 alexr00 enabled auto-merge (rebase) August 28, 2023 20:11
@alexr00 alexr00 disabled auto-merge August 28, 2023 20:11
@alexr00 alexr00 enabled auto-merge (squash) August 28, 2023 20:11
@alexr00 alexr00 disabled auto-merge August 28, 2023 20:11
@alexr00 alexr00 enabled auto-merge (squash) August 28, 2023 20:11
@lszomoru
Copy link
Member

@alexr00, is this something that you would like to get checked in in August or can this slip to September?

@alexr00
Copy link
Member Author

alexr00 commented Aug 29, 2023

September is fine.

@alexr00 alexr00 modified the milestones: August 2023, September 2023 Aug 29, 2023
@alexr00 alexr00 merged commit 1ac6f50 into main Sep 4, 2023
6 checks passed
@alexr00 alexr00 deleted the alexr00/gitLogBetween branch September 4, 2023 12:36
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants