Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

focus hover on escape of accessible view so context isn't lost #189074

Merged
merged 2 commits into from
Jul 27, 2023
Merged

focus hover on escape of accessible view so context isn't lost #189074

merged 2 commits into from
Jul 27, 2023

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Jul 27, 2023 •
edited

this fix is not ideal, but it's a critical issue and makes the feature unusable since focus is lost for screen reader users.

fix #188822

see gif at the bottom of the issue

@meganrogge meganrogge self-assigned this Jul 27, 2023
@meganrogge meganrogge added this to the July 2023 milestone Jul 27, 2023
@meganrogge meganrogge requested a review from Tyriar July 27, 2023 16:46
roblourens
roblourens previously approved these changes Jul 27, 2023
View reviewed changes
Tyriar
Tyriar previously approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure there's a follow up issue for this

@meganrogge meganrogge mentioned this pull request Jul 27, 2023
Closed
@andreamah
Copy link
Contributor

failed CI -> Property 'showAndFocusLastHover' is missing in type 'TestHoverService' but required in type 'IHoverService'.

@meganrogge meganrogge dismissed stale reviews from Tyriar and roblourens via 75c8905 July 27, 2023 17:56
@meganrogge meganrogge merged commit 56614fb into main Jul 27, 2023
6 checks passed
@meganrogge meganrogge deleted the merogge/focus-last-hover branch July 27, 2023 18:10
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@connor4312 connor4312 connor4312 approved these changes

@roblourens roblourens roblourens left review comments

@Tyriar Tyriar Tyriar left review comments

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
July 2023
Development

Successfully merging this pull request may close these issues.

Focus is lost after closing accessible view
5 participants
@meganrogge @andreamah @roblourens @Tyriar @connor4312