alert when focus changes for chat responses/ notifications in the accessible view #189090
Conversation
commit 0d28b2e Merge: b5a4613 074b93d Author: Megan Rogge <merogge@microsoft.com> Date: Thu Jul 27 12:36:22 2023 -0700 Merge pull request #189090 from microsoft/merogge/alert-focus-change alert when focus changes for chat responses/ notifications in the accessible view commit 074b93d Author: meganrogge <megan.rogge@microsoft.com> Date: Thu Jul 27 12:19:59 2023 -0700 fix bug commit 1320f52 Author: meganrogge <megan.rogge@microsoft.com> Date: Thu Jul 27 12:18:30 2023 -0700 clean up commit b5a4613 Author: Meghan Kulkarni <kulkarni.meg@gmail.com> Date: Thu Jul 27 12:13:03 2023 -0700 Markdown link pasting does not encode or decode links (#188992) * uris pasted with no encoding or decoding * add tests for checking encoding commit b7bf8b0 Author: meganrogge <megan.rogge@microsoft.com> Date: Thu Jul 27 12:11:05 2023 -0700 fix commit f7a4e0d Author: meganrogge <megan.rogge@microsoft.com> Date: Thu Jul 27 12:01:13 2023 -0700 fix #188831
|
It is working as I would expect on Windows. Unfortunately, I still don't have the environment ready on macOS, so cannot verify there until Insider comes up. One small problem that remains is that, if I try to move pass the first or the last item, the widget gets refocused as if it had been a transition when really nothing has happened. If I try to move beyond first or last item, it should either wrap around or produce an indication that the limit has been reached in that direction. Even repeating the alert ("focused 2 of 2") would be fine in my opinion. |
|
@rperez030 thanks for testing. isn't the fact that it tells you the length sufficient given you know it's reached the end (if index = length) or beginning (if index = 1)? @jooyoungseo has sometimes said that wrapping isn't ideal - perhaps you/he might feel differently in this case. I'm not sure we can support that - it could get complicated, but i'll consider it if it would be better in your opinions. |
Wrapping around doesn't sound ideal to me either. Let's see there are 3 elements, and I'm focus on 2 of 3. If I press the next command, the widget gets refocused, and it announces focused 3 of 3. Good until here. If I press the next command again, the widget gets refocused, but since there is no real change, position information is not reannounced. In other words, If I'm not sure the current element is the last one, pressing the next command will not help me. I would need to go backwards to get confirmation on what's going on. One way of resolving this would be repeating the position information when I press any of the commands, even if there is no change. Another possibility would be to prevent the widget from refocusing when I am in the first / last element, and I try to move beyond that element. In that way pressing the next command will not produce any feedback if I am in the last one, and the previous will not produce any feedback if I am in the first one. Does it make sense? In any case, this would be a refinement, not something that would prevent someone from using the feature. |
fix #188831
cc @rperez030