fix: bump node-gyp dependency to v9.4.0 #189308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
force-pushed
the
robo/fix_windows_build
branch
from
6fdd0c3
to
c065592
Compare
deepak1556
force-pushed
the
robo/fix_windows_build
branch
from
c065592
to
ea87de6
Compare
connor4312
approved these changes
Jul 31, 2023
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the build failure in Windows CI , https://dev.azure.com/monacotools/Monaco/_build/results?buildId=225817&view=results
Adopts nodejs/node-gyp@7a3fe1c which only downloads headers for the target architecture allowing us to omit Windows arm64 headers for remote.
Additionally the PR drops the use of node-gyp fork in CI, /cc @rzhao271
Fixes #189312