Honor --disable-keytar and fix event handling in the browser
#189514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have always had a way to disable reading from the keyring and use an in-memory secrets storage: `--disable-keytar`. This honors that flag in the new SecretStorage world... in a follow up PR we will migrate that flag to `--disable-secret-storage`. Additionally, I found a bug where we weren't firing events that we successfully set/deleted secrets in the browser version of secretStorageService and this fixes that by firing those events. This also reverts #189489 so that `BaseSecretStorageService.type` reads correctly early on... plus there's more discussion to be had in #189481 Fixes #188432
roblourens
approved these changes
Aug 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have always had a way to disable reading from the keyring and use an in-memory secrets storage:
--disable-keytar.This honors that flag in the new SecretStorage world... in a follow up PR we will migrate that flag to
--disable-secret-storage.Additionally, I found a bug where we weren't firing events that we successfully set/deleted secrets in the browser version of secretStorageService and this fixes that by firing those events.
This also reverts #189489 so that
BaseSecretStorageService.typereads correctly early on... plus there's more discussion to be had in #189481Oh, and tests 馃殌
Fixes #188432