Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Settings editor smoke tests #189687

Merged
merged 5 commits into from
Aug 7, 2023
Merged

Add Settings editor smoke tests #189687

merged 5 commits into from
Aug 7, 2023

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Aug 4, 2023

Fixes #141054

@rzhao271 rzhao271 self-assigned this Aug 4, 2023
@rzhao271 rzhao271 added this to the August 2023 milestone Aug 4, 2023
@rzhao271 rzhao271 requested a review from Tyriar August 4, 2023 23:28
Tyriar
Tyriar previously approved these changes Aug 5, 2023
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good provided they pass

Copy link

@Oguidan Oguidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@Oguidan
Copy link

Oguidan commented Aug 5, 2023

@rzhao271 I want you to mentor me, please I need you. Can you?

@rzhao271 rzhao271 merged commit e1dfb2a into main Aug 7, 2023
6 checks passed
@rzhao271 rzhao271 deleted the rzhao271/civic-kingfisher branch August 7, 2023 15:22
rzhao271 added a commit that referenced this pull request Aug 7, 2023
rzhao271 added a commit that referenced this pull request Aug 7, 2023
Revert "Add Settings editor smoke tests (#189687)"

This reverts commit e1dfb2a.
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants