add help menu for accessible views #189883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
Aug 8, 2023
| } | ||
| } | ||
| if (helpHint) { | ||
| ariaLabel = provider.options.ariaLabel ? localize('helpAriaKb', "{0}, {1}", provider.options.ariaLabel, helpHint) : localize('accessible-view', "Accessible View, {0}", helpHint); |
There was a problem hiding this comment.
The first one just localizes a comma
There was a problem hiding this comment.
Not sure what you mean
roblourens
reviewed
Aug 8, 2023
roblourens
approved these changes
Aug 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #189824
adds help menus for the accessible views and adds a hint to the aria label about opening accessibility help to reduce aria label size.
there's still an issue where when going from the view to the help dialog, the focus on macos doesn't get updated
cc @rperez030 this is the same thing where the focus is on the right element, but VoiceOver doesn't notice that until the cursor is moved.