Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for actionWidget (#187492) #189955

Merged
merged 5 commits into from
Aug 8, 2023
Merged

Conversation

justschen
Copy link
Contributor

@justschen justschen commented Aug 8, 2023

hotfixes #187492, but as mentioned before, the use of the !important isn't super ideal. Will continue to look into cleaning up the styling and looking into the production issue mentioned in #162952.

edit: no longer adds an !important and may or may not fix production issue of incorrect highlights.

@justschen
Copy link
Contributor Author

justschen commented Aug 8, 2023

It's a little tricky but I might just add another css selector in the listWidget's base styling to avoid using !important

Here is the DefaultStyleController, and something like content.push(.monaco-list${suffix}:focus .monaco-list-row.focused.option-disabled { color: ${styles.listFocusForeground}; }); adding an option-disabled selector.

Recording 2023-08-08 at 11 02 26 (1)

@justschen justschen requested a review from mjbvz August 8, 2023 19:56
@justschen justschen marked this pull request as ready for review August 8, 2023 21:31
@VSCodeTriageBot VSCodeTriageBot added this to the August 2023 milestone Aug 8, 2023
@justschen justschen enabled auto-merge (squash) August 8, 2023 21:33
@justschen justschen merged commit 49ac847 into microsoft:main Aug 8, 2023
6 checks passed
justschen added a commit that referenced this pull request Aug 9, 2023
…dding specificity (#190077)

* bugfix on selected list item reverting and added important

* removed !important and added specificity
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants