Realign slash command content widget in panel chat #190053
Conversation
| @@ -4,7 +4,8 @@ | |||
| *--------------------------------------------------------------------------------------------*/ | |||
|
|
|||
| .chat-slash-command-content-widget { | |||
| padding: 0 3px 1px 3px; | |||
| padding: 1px 2px 0px 1px; | |||
There was a problem hiding this comment.
Possible to do this without changing the internal cell padding?
There was a problem hiding this comment.
Sorry I don't follow, can you elaborate?
There was a problem hiding this comment.
Sorry, wrong word choice above. This changes the padding of the pill itself which might make it look lopsided the top has visibly more padding than the bottom or vice versa. Note the extra top space in the pill pictured in the issue for createWorkspace.
Ideally the pill, pill text, and input text can all be vertically dead center and then we don't have to worry about lopsided padding.
IIRC you can change the input editor text position with some editor API? Happy to checkout and take a look if you'd like.
There was a problem hiding this comment.
I think the issue is that the input text outside the pill is itself 1px below dead center, which is noticeable if you enter some text and hit ctrl+a (shown below), so if we want the text inside the pill to be vertically centered, it will be misaligned with the other text in the input. IMO it's more important that the text inside the pill is aligned with text outside the pill, I pushed a change which tries to do this:
There was a problem hiding this comment.
Looks great. Made one change to align everything vertically as a group.
Fix #190039