Fixing the cancellation error on quick typing in sticky scroll #190161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieken
requested changes
Aug 10, 2023
src/vs/editor/contrib/stickyScroll/browser/stickyScrollModelProvider.ts
Outdated
Show resolved
Hide resolved
okineadev
approved these changes
Aug 10, 2023
jrieken
approved these changes
Aug 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #179863
Error is thrown because when trigger scheduler is cancelled and the promise it is meant to fulfil is not fulfilled yet, it throws an error. The trigger scheduler however is called on every model change, and if you type sufficiently quickly the above conditions are verified and errors are thrown. The fix presented here is to ignore errors thrown inside of the promise.