Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync xterm's textarea with buffer contents #190294

Merged
merged 27 commits into from
Aug 15, 2023
Merged

sync xterm's textarea with buffer contents #190294

merged 27 commits into from
Aug 15, 2023

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Aug 11, 2023

fixes #186904

@meganrogge meganrogge requested a review from Tyriar August 11, 2023 22:06
@meganrogge meganrogge self-assigned this Aug 11, 2023
@meganrogge meganrogge added this to the August 2023 milestone Aug 11, 2023
@meganrogge
Copy link
Contributor Author

meganrogge commented Aug 14, 2023

@Tyriar mostly working now, except if I do cmd+backspace. When I put a breakpoint here, it works 🤔. This also does not work when I blur (focus out) the terminal. Tried handling focus change and syncing when that happens and didn't work

textarea.mov

@meganrogge meganrogge requested a review from Tyriar August 14, 2023 22:40
@meganrogge
Copy link
Contributor Author

surprising errors given I didn't change this line 🤔

// Importing types is safe in any layer
// eslint-disable-next-line local/code-import-patterns
import type { IBuffer, IBufferLine, IDisposable, IMarker, Terminal } from 'xterm-headless';

@meganrogge meganrogge requested a review from Tyriar August 15, 2023 18:20
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after the couple of comments

Not sure about the monaco check failure, @hediet do you know why it thinks platform/terminal is part of monaco?

meganrogge and others added 2 commits August 15, 2023 14:56
…/terminal.accessibility.contribution.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@meganrogge meganrogge requested a review from Tyriar August 15, 2023 22:12
@meganrogge meganrogge merged commit 7a464d6 into main Aug 15, 2023
5 of 6 checks passed
@meganrogge meganrogge deleted the merogge/xterm-acc branch August 15, 2023 22:30
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants