Find with selected values when reveal TerminalFind #190466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reveal TerminalFind
meganrogge
previously approved these changes
Aug 15, 2023
meganrogge
reviewed
Aug 15, 2023
| @@ -81,9 +81,9 @@ export class TerminalFindWidget extends SimpleFindWidget { | |||
| override reveal(): void { | |||
| const initialInput = this._instance.hasSelection() && !this._instance.selection!.includes('\n') ? this._instance.selection : undefined; | |||
| const xterm = this._instance.xterm; | |||
| if (xterm && this.inputValue && this.inputValue !== '') { | |||
| if (xterm && initialInput && initialInput !== '') { | |||
There was a problem hiding this comment.
do we want to fallback to this.inputValue if initialInput is undefined?
There was a problem hiding this comment.
I need to adjust and test it.
connor4312
previously approved these changes
Aug 15, 2023
initialInput is undefined
|
hi @meganrogge , fallback to
|
TylerLeonhardt
approved these changes
Aug 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #189343