Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding typescript diagnostic error codes in typescript extension #190485

Merged
merged 24 commits into from
Aug 25, 2023
Merged

Adding typescript diagnostic error codes in typescript extension #190485

merged 24 commits into from
Aug 25, 2023

Conversation

aiday-mar
Copy link
Contributor

@aiday-mar aiday-mar commented Aug 15, 2023 •
edited

@aiday-mar aiday-mar self-assigned this Aug 15, 2023
@aiday-mar aiday-mar marked this pull request as ready for review August 15, 2023 10:21
@VSCodeTriageBot VSCodeTriageBot added this to the August 2023 milestone Aug 15, 2023
@alexdima alexdima requested a review from mjbvz August 15, 2023 12:46
@aiday-mar aiday-mar marked this pull request as draft August 18, 2023 08:00
@aiday-mar aiday-mar marked this pull request as ready for review August 18, 2023 11:02
@aiday-mar aiday-mar requested a review from mjbvz August 18, 2023 11:03
alexdima
alexdima requested changes Aug 18, 2023
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments

extensions/typescript-language-features/src/languageFeatures/diagnostics.ts Outdated Show resolved Hide resolved
extensions/typescript-language-features/src/languageFeatures/diagnostics.ts Outdated Show resolved Hide resolved
extensions/typescript-language-features/src/languageFeatures/diagnostics.ts Outdated Show resolved Hide resolved
extensions/typescript-language-features/src/languageFeatures/diagnostics.ts Outdated Show resolved Hide resolved
extensions/typescript-language-features/src/languageFeatures/diagnostics.ts Outdated Show resolved Hide resolved
extensions/typescript-language-features/src/languageFeatures/diagnostics.ts Outdated Show resolved Hide resolved
extensions/typescript-language-features/src/languageFeatures/diagnostics.ts Outdated Show resolved Hide resolved
extensions/typescript-language-features/src/languageFeatures/diagnostics.ts Show resolved Hide resolved
alexdima
alexdima requested changes Aug 21, 2023
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left more comments

extensions/typescript-language-features/src/languageFeatures/diagnostics.ts Outdated Show resolved Hide resolved
extensions/typescript-language-features/src/languageFeatures/diagnostics.ts Outdated Show resolved Hide resolved
extensions/typescript-language-features/src/languageFeatures/diagnostics.ts Outdated Show resolved Hide resolved
alexdima
alexdima requested changes Aug 21, 2023
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left another comment

extensions/typescript-language-features/src/languageFeatures/diagnostics.ts Outdated Show resolved Hide resolved
@aiday-mar aiday-mar requested a review from mjbvz August 24, 2023 09:02
@alexdima alexdima self-requested a review August 24, 2023 09:59
alexdima
alexdima approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiday-mar aiday-mar merged commit cb1cdd8 into main Aug 25, 2023
6 checks passed
@aiday-mar aiday-mar deleted the aiday/telemetryDiagnosticData branch August 25, 2023 06:43
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexdima alexdima alexdima approved these changes

@mjbvz mjbvz mjbvz approved these changes

Assignees

@aiday-mar aiday-mar

Labels
None yet
Projects
None yet
Milestone
August 2023
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aiday-mar @alexdima @mjbvz @VSCodeTriageBot