eng: cleanup some leaks around around editors and workbenchInstantiationService #190623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes some leaks I found while looking at #190444, by adding ensureNoDisposablesAreLeakedInTestSuite to the suite. I don't have a dev setup for inline chat, so I have not tested this beyond running tests and verifying the fix
…ionService I added a disposable leak tracker to a test that used `workbenchInstantiationService`. This fixes the baseline leaks and some extra leaks with that function.
DonJayamanne
previously approved these changes
Aug 16, 2023
|
@connor4312 this is very cool but should probably be reviewed by each respective component owner? |
jrieken
requested changes
Aug 17, 2023
src/vs/workbench/contrib/inlineChat/test/browser/inlineChatController.test.ts
Outdated
Show resolved
Hide resolved
|
cc other owners @joaomoreno @hediet @alexdima @sbatten please let me know if anything you own in this PR looks concerning |
hediet
approved these changes
Aug 18, 2023
jrieken
approved these changes
Aug 18, 2023
|
🙅 This needs to be reopened until I had a chance to review. |
connor4312
added a commit
that referenced
this pull request
Aug 18, 2023
This reverts commit 6336ee7.
connor4312
added a commit
that referenced
this pull request
Aug 18, 2023
This reverts commit 6336ee7.
connor4312
added a commit
that referenced
this pull request
Aug 21, 2023
Re-applies #190623 which I merged before everyone had a chance to review. Alex and Ben, you were the two people whose code this touches and didn't review it in the original PR.
bpasero
added a commit
that referenced
this pull request
Aug 23, 2023
* eng: reapply test leak fixes Re-applies #190623 which I merged before everyone had a chance to review. Alex and Ben, you were the two people whose code this touches and didn't review it in the original PR. * 💄 * fix merge * better handling of editor listeners --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Krzysztof-Cieslak
pushed a commit
to githubnext/vscode
that referenced
this pull request
Sep 18, 2023
…ionService (microsoft#190623) * inline chat: fix leaks found in testing Fixes some leaks I found while looking at microsoft#190444, by adding ensureNoDisposablesAreLeakedInTestSuite to the suite. I don't have a dev setup for inline chat, so I have not tested this beyond running tests and verifying the fix * eng: cleanup some leaks around around editors and workbenchInstantiationService I added a disposable leak tracker to a test that used `workbenchInstantiationService`. This fixes the baseline leaks and some extra leaks with that function. * fix build * rm too-eager leak checker * remove forgotten busy loop
Krzysztof-Cieslak
pushed a commit
to githubnext/vscode
that referenced
this pull request
Sep 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a disposable leak tracker to a test that used
workbenchInstantiationService.This fixes the baseline leaks and some extra leaks with that function.