Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progressbar #190708

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Add progressbar #190708

merged 2 commits into from
Aug 18, 2023

Conversation

rzhao271
Copy link
Contributor

Remote setting searches take noticeably longer for the results to come in, so this PR adds a progress bar to the top of the Settings editor that starts when the search starts, and stops when all the search results are in.

@rzhao271 rzhao271 enabled auto-merge (squash) August 17, 2023 22:20
@rzhao271 rzhao271 self-assigned this Aug 17, 2023
@rzhao271 rzhao271 added this to the August 2023 milestone Aug 17, 2023
@rzhao271
Copy link
Contributor Author

I just noticed that the Notebook editor uses a service instead.

@rzhao271 rzhao271 disabled auto-merge August 17, 2023 22:35
@rzhao271 rzhao271 enabled auto-merge (squash) August 17, 2023 22:35
@rzhao271 rzhao271 merged commit 349c93d into main Aug 18, 2023
6 checks passed
@rzhao271 rzhao271 deleted the rzhao271/se-progressbar branch August 18, 2023 22:20
Krzysztof-Cieslak pushed a commit to githubnext/vscode that referenced this pull request Sep 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants