Don't use remoteCredentialsService when client specified a secretStorageProvider
#190781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torageProvider` This is a temporary fix for #190537 until we clean up the last of the CredentialsService (which should be in debt week in Sept). If the client embedder declared a secretStorageProvider, they likely don't want the old credentialsProvider to go over the remote connection... so we use an in-memory provider instead. Fixed #190537
Tyriar
approved these changes
Aug 18, 2023
Krzysztof-Cieslak
pushed a commit
to githubnext/vscode
that referenced
this pull request
Sep 18, 2023
…torageProvider` (microsoft#190781) * Don't use `remoteCredentialsService` when client specified a `secretStorageProvider` This is a temporary fix for microsoft#190537 until we clean up the last of the CredentialsService (which should be in debt week in Sept). If the client embedder declared a secretStorageProvider, they likely don't want the old credentialsProvider to go over the remote connection... so we use an in-memory provider instead. Fixed microsoft#190537 * remove stale comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix for #190537
until we clean up the last of the CredentialsService (which should be in debt week in Sept).
If the client embedder declared a secretStorageProvider, they likely don't want the old credentialsProvider to go over the remote connection... so we use an in-memory provider instead.
Fixed #190537