eng: reapply test leak fixes #190890
Merged
eng: reapply test leak fixes #190890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-applies #190623 which I merged before everyone had a chance to review. Alex and Ben, you were the two people whose code this touches and didn't review it in the original PR.
alexdima
previously approved these changes
Aug 21, 2023
|
Looks good to me! Thanks for improving all of this! |
bpasero
requested changes
Aug 22, 2023
There was a problem hiding this comment.
I do not feel confident about the changes to listenStream, so I suggest to move those changes out of this PR. Maybe rather than returning a IDisposable, the method listenStream should optionally allow you to pass in a CancellationToken.
Left some minor feedback for the rest.
bpasero
approved these changes
Aug 23, 2023
dbaeumer
approved these changes
Aug 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-applies #190623 which I merged before everyone had a chance to review.
Alex and Ben, you were the two people whose code this touches and didn't
review it in the original PR.