Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Dynamic 'skipFiles' support and UI #19096

Closed
2 tasks done
roblourens opened this issue Jan 23, 2017 · 0 comments
Closed
2 tasks done

Test: Dynamic 'skipFiles' support and UI #19096

roblourens opened this issue Jan 23, 2017 · 0 comments
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Milestone

Comments

@roblourens
Copy link
Member

roblourens commented Jan 23, 2017

Test for #14728
Complexity: 4

Should probably cover both path types:

We previously supported having the skipFiles attribute in the launch config. Now, you can also right click on a stack frame to skip or un-skip it.

Using node2, check these things:

  • Skipped frames, whether by launch config or context menu, are grayed out in the callstack
  • If you right click to skip/unskip a file, it is actually skipped/unskipped
  • If a file is skipped by the launch config, it can be unskipped by right clicking

If you aren't sure what code to test, I usually write something like this:

a.ts:

import * as b from './b';

function f() {
  console.log('f');
}

b.callback(f);

b.ts

export function callback(cb) {
  cb();
}

Then you can easily verify that when b.ts is skipped, you can do a step-in to step directly from b.callback(f) to f.

@roblourens roblourens added debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item labels Jan 23, 2017
@egamma egamma modified the milestone: January 2017 Jan 23, 2017
@jrieken jrieken removed their assignment Jan 24, 2017
@ramya-rao-a ramya-rao-a removed their assignment Jan 25, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Projects
None yet
Development

No branches or pull requests

4 participants