Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turning off sticky scroll when model is too large for tokenization #191072

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Turning off sticky scroll when model is too large for tokenization #191072

merged 2 commits into from
Aug 24, 2023

Conversation

aiday-mar
Copy link
Contributor

Fixes #191064

@aiday-mar aiday-mar self-assigned this Aug 23, 2023
@aiday-mar aiday-mar marked this pull request as ready for review August 23, 2023 13:03
@VSCodeTriageBot VSCodeTriageBot added this to the August 2023 milestone Aug 23, 2023
alexdima
alexdima requested changes Aug 23, 2023
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces a bug when going to a file where sticky scroll works and then switching to a very large file:

Kapture.2023-08-23.at.19.47.40.mp4

@aiday-mar aiday-mar requested a review from aeschli August 24, 2023 09:20
alexdima
alexdima approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@aiday-mar aiday-mar merged commit 10c075c into main Aug 24, 2023
6 checks passed
@aiday-mar aiday-mar deleted the aiday/modelTooLargeForTokenization branch August 24, 2023 10:09
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexdima alexdima alexdima approved these changes

@aeschli aeschli Awaiting requested review from aeschli

Assignees

@aiday-mar aiday-mar

Labels
None yet
Projects
None yet
Milestone
August 2023
Development

Successfully merging this pull request may close these issues.

Large files: Sticky scroll should be disabled like wrapping
3 participants
@aiday-mar @alexdima @VSCodeTriageBot