suppport alt+f2, ctrl/cmd+Up/DownArrow to go to terminal accessible buffer, synchronize windows/mac keybinding for command nav in accessible buffer
#191108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
changed the title
alt+f2, ctrl/cmd+Up/DownArrow to go to terminal accessible bufferalt+f2, ctrl/cmd+Up/DownArrow to go to terminal accessible buffer, synchronize windows/mac keybinding for command nav in accessible buffer
Tyriar
previously requested changes
Aug 24, 2023
| @@ -22,6 +22,10 @@ export const terminalStrings = { | |||
| value: localize('workbench.action.terminal.focus', "Focus Terminal"), | |||
| original: 'Focus Terminal' | |||
| }, | |||
| focusAndHideAccessibleBuffer: { | |||
| value: localize('workbench.action.terminal.focusAndHideAccessibleBuffer', "Focus Terminal and Hide Accessible Buffer"), | |||
| original: 'Focus Terminal and Hide Accessible Buffer' | |||
There was a problem hiding this comment.
Can this be the default behavior of the focus terminal command? As opposed to FocusAccessibleBuffer which focuses the accessible buffer, not the textarea?
There was a problem hiding this comment.
I tried that originally. that does not work because hide has to be called on the accessible view component and we cannot access that here. can refactor this when we move over to using the accessible view for this in the future
There was a problem hiding this comment.
I think you could handle that with ITerminalInstance.onDidFocus
There was a problem hiding this comment.
that's what I tried initially. It was confusing because the event is named onDidRequestFocus
...rkbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts
Outdated
Show resolved
Hide resolved
...rkbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts
Outdated
Show resolved
Hide resolved
...rkbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts
Outdated
Show resolved
Hide resolved
...rkbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleWidget.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleWidget.ts
Outdated
Show resolved
Hide resolved
hediet
reviewed
Aug 24, 2023
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleWidget.ts
Show resolved
Hide resolved
hediet
approved these changes
Aug 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #188927
fixes #189360
Re this one, I think it makes sense to unify across platforms for screen reader users. It doesn't present an inconsistency as currently, in the terminal, ctrl+up/down does not jump to commands.
fixes #189358