Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to code action from setting #191809

Merged
merged 6 commits into from
Sep 1, 2023
Merged

Change to code action from setting #191809

merged 6 commits into from
Sep 1, 2023

Conversation

aiday-mar
Copy link
Contributor

@aiday-mar aiday-mar commented Aug 30, 2023 •
edited

Fixes #191647

The kind is source.sort.json so that sorting on save can be activated with either of these strings:

source
source.sort
source.sort.json

@aiday-mar aiday-mar self-assigned this Aug 30, 2023
@aiday-mar aiday-mar requested a review from aeschli August 31, 2023 14:06
@aiday-mar aiday-mar marked this pull request as ready for review August 31, 2023 14:06
@Thatsdead95 Thatsdead95 mentioned this pull request Sep 1, 2023
Closed
@aiday-mar aiday-mar merged commit 0868714 into main Sep 1, 2023
6 checks passed
@aiday-mar aiday-mar deleted the aiday/codeActionInsteadOfSetting branch September 1, 2023 17:11
@fannheyward fannheyward mentioned this pull request Sep 11, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aeschli aeschli aeschli approved these changes

Assignees

@aiday-mar aiday-mar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should json sorting be a source action instead of a setting
2 participants
@aiday-mar @aeschli