Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in zsh si script #191822

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fix error in zsh si script #191822

merged 1 commit into from
Aug 30, 2023

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 30, 2023

Fixes #188875

Screenshot 2023-08-30 at 10 05 16 AM

@Tyriar Tyriar added this to the August 2023 milestone Aug 30, 2023
@Tyriar Tyriar requested a review from karrtikr August 30, 2023 17:05
@Tyriar Tyriar self-assigned this Aug 30, 2023
@Tyriar Tyriar enabled auto-merge August 30, 2023 17:06
karrtikr
karrtikr reviewed Aug 30, 2023
View reviewed changes
Copy link
Contributor

@karrtikr karrtikr left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Although there does not seem be a space between the prepended character and rest of the string.

@Tyriar
Copy link
Member Author

Tyriar commented Aug 30, 2023

@karrtikr that's by design as my test extension prepended "(.venv)", not "(.venv) "

karrtikr
karrtikr approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay

@Tyriar Tyriar merged commit 95e0d5c into main Aug 30, 2023
7 checks passed
@Tyriar Tyriar deleted the tyriar/188875 branch August 30, 2023 17:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karrtikr karrtikr karrtikr approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
August 2023
Development

Successfully merging this pull request may close these issues.

Prepending fails on zsh with only shell integration enabled
2 participants
@Tyriar @karrtikr