Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix undefined check, get textarea sync to work for windows #191912

Merged
merged 5 commits into from
Aug 31, 2023
Merged

fix undefined check, get textarea sync to work for windows #191912

merged 5 commits into from
Aug 31, 2023

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Aug 31, 2023 •
edited

fix #186904

@meganrogge meganrogge self-assigned this Aug 31, 2023
@meganrogge meganrogge added this to the August 2023 milestone Aug 31, 2023
@meganrogge meganrogge marked this pull request as draft August 31, 2023 14:49
@meganrogge meganrogge requested a review from Tyriar August 31, 2023 14:49
Tyriar
Tyriar previously approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fairly safe to me 👍

@meganrogge
Copy link
Contributor Author

turns out that did cause issues on mac, so glad I checked.

@meganrogge meganrogge marked this pull request as ready for review August 31, 2023 15:06
@meganrogge meganrogge requested a review from Tyriar August 31, 2023 15:23
@meganrogge
Copy link
Contributor Author

meganrogge commented Aug 31, 2023 •
edited

this was working on windows before my last commit... investigating

@meganrogge meganrogge changed the title use command start x of 0 if undefined, get textarea sync to work for windows fix undefined check, get textarea sync to work for windows Aug 31, 2023
@meganrogge meganrogge requested a review from Tyriar August 31, 2023 16:13
@meganrogge @Tyriar
Update src/vs/workbench/contrib/terminalContrib/accessibility/browser…
a3d842e 
…/textAreaSyncAddon.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@meganrogge meganrogge merged commit 3cd6f48 into main Aug 31, 2023
6 checks passed
@meganrogge meganrogge deleted the merogge/windows-command-start branch August 31, 2023 16:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
August 2023
2 participants
@meganrogge @Tyriar