-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fill selection text for quick search #191956
Conversation
This is a simple version, there are still many problems to solve, i.e. if we select a word in the editor, but we switch the cursor to the left search window, and let the cursor in the input box, the shortcut search will still fill the editor selected word, I think it should not be filled at this time, so I will add judgment for editor is focus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for working on this! Just some small comments.
src/vs/workbench/contrib/search/browser/searchActionsTextQuickAccess.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/search/browser/searchActionsTextQuickAccess.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! just a few more nitpicks
These are all help to correct my code progress ~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for not commenting on this earlier - I just noticed this while testing your PR.
This reverts commit 7014efc.
@TylerLeonhardt This PR looks fine to me, but I did notice that this doesn't work if vscode/src/vs/platform/quickinput/browser/quickAccess.ts Lines 83 to 87 in 26f41a4
Should we edit this somehow, or is this intentional? |
src/vs/workbench/contrib/search/browser/searchActionsTextQuickAccess.ts
Outdated
Show resolved
Hide resolved
@andreamah that seems backwards to me. Can you get an issue going and I'll take a look deeper? |
Excited to see this land! Thanks, @weartist! |
For: #191513