Debounce F4/shift F4

[joaomoreno]

Testing #19094

1. Have many search results in the search viewlet
2. Select the first
3. Hold Down Arrow key

You'll notice that a file will open every 300ms or so, demonstrating the rate limiting.

This UI interaction should use debouncing instead of limiting the rate. We have a few utils for this.

[joaomoreno]

Additionally, why are the arrow keys rate limiting, but F4 and Shift F4 are not? IMO they should all behave the same way: debounced.

[roblourens]

I tried debouncing originally but thought it was even more annoying than rate limiting because typically with a debounce, there's a delay before the first one takes effect. I'll play around with this some more though since it doesn't look great as is. Good point on F4

[roblourens]

Fixed in #19307 but will also do this for F4

[joaomoreno]

Cool. 👍 Just finely tune the debouncing delay to fix the annoyance.

[roblourens]

Actually this probably won't happen for January. When using F4, the editor is focused. When you hold F4, we would want to see each next result being focused, like when holding the down arrow, but currently the focused result isn't highlighted in the search viewlet when it doesn't have focus. Only the selected result (which is open in the editor) is highlighted. So I'd have to change that. Will look at it for February.