rm terminal tab focus mode #192000
Merged
rm terminal tab focus mode #192000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-merge was automatically disabled
September 5, 2023 13:14
Pull request was converted to draft
|
@Tyriar not sure, but think you missed this |
roblourens
approved these changes
Sep 6, 2023
Tyriar
reviewed
Sep 7, 2023
| @@ -726,7 +726,7 @@ export interface IEditorOptions { | |||
| pasteAs?: IPasteAsOptions; | |||
|
|
|||
| /** | |||
| * Controls whether the editor receives tabs or defers them to the workbench for navigation. | |||
There was a problem hiding this comment.
We shouldn't mention terminal anywhere in vs/editor
| @@ -3690,7 +3690,7 @@ declare namespace monaco.editor { | |||
| */ | |||
| pasteAs?: IPasteAsOptions; | |||
| /** | |||
| * Controls whether the editor receives tabs or defers them to the workbench for navigation. | |||
There was a problem hiding this comment.
We really shouldn't mention terminal here as it's monaco's public API where a terminal doesn't exist.
Comment on lines
+326
to
+330
| if (tabFocusMode !== undefined) { | ||
| this.onTabFocusModeChange(tabFocusMode); | ||
| } else { | ||
| this.onTabFocusModeChange(this.configurationService.getValue('editor.tabFocusMode')); | ||
| } |
There was a problem hiding this comment.
Nice imo:
this.onTabFocusModeChange(tabFocusMode ?? this.configurationService.getValue('editor.tabFocusMode'));
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #191938