Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug: fix launch task doesn't run if similar task is already running in different workspace folder #192249

Merged
merged 2 commits into from
Sep 6, 2023
Merged

debug: fix launch task doesn't run if similar task is already running in different workspace folder #192249

merged 2 commits into from
Sep 6, 2023

Conversation

connor4312
Copy link
Member

Fixes #191949

@connor4312 connor4312 enabled auto-merge (squash) September 6, 2023 00:22
@connor4312 connor4312 self-assigned this Sep 6, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the September 2023 milestone Sep 6, 2023
roblourens
roblourens previously approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems right, I see a couple other references to _id in this file but I can't tell whether they're problematic

@connor4312
Copy link
Member Author

ah, I missed some. I think they should all be moved.

@connor4312 connor4312 merged commit e00e7db into main Sep 6, 2023
6 checks passed
@connor4312 connor4312 deleted the connor4312/issue191949 branch September 6, 2023 02:19
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees

@connor4312 connor4312

Labels
None yet
Projects
None yet
Milestone
September 2023
Development

Successfully merging this pull request may close these issues.

Pre launch task doesn't run if similar task is already running in different workspace folder
3 participants
@connor4312 @roblourens @VSCodeTriageBot