tasks: use a type union for ITaskEvent #192314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When fixing a bug in tests I noticed that all properties of the ITaskEvent were optional, so I had to go into task code to figure out what types I could use. This PR refactors the types so ITaskEvent is a union type that provides as much information as possible about the presence of properties. I tested this on some projects but am not sure if there's a repo/project to test out the full gamut of task functionality. But there should be no (barring once, see comment) functional change.
connor4312
commented
Sep 6, 2023
| if (reconnectedTerminal) { | ||
| if ('command' in task && task.command.presentation) { | ||
| reconnectedTerminal.waitOnExit = getWaitOnExitValue(task.command.presentation, task.configurationProperties); | ||
| } | ||
| reconnectedTerminal.onDisposed((terminal) => this._fireTaskEvent({ kind: TaskEventKind.Terminated, exitReason: terminal.exitReason, taskId: task.getRecentlyUsedKey() })); |
There was a problem hiding this comment.
This is the one functional change. I'm pretty sure taskId: task.getRecentlyUsedKey() was a bug or at least a hack; the task ID and recently used key are not interchangable and other places where Terminated is fired do not use the recently used key in place of ID.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fixing a bug in debug I noticed that all properties of the
ITaskEvent were optional, so I had to go into task code to figure out
what types I could use.
This PR refactors the types so ITaskEvent is a union type that provides
as much information as possible about the presence of properties.
I tested this on some projects but am not sure if there's a repo/project
to test out the full gamut of task functionality. But there should be
no (barring one, see comment) functional change.