Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editor paste event result return ClipboardEvent #192732

Merged
merged 9 commits into from
Mar 16, 2024
Merged

editor paste event result return ClipboardEvent #192732

merged 9 commits into from
Mar 16, 2024

Conversation

deyihu
Copy link
Contributor

@deyihu deyihu commented Sep 11, 2023

fix #192729

@deyihu deyihu mentioned this pull request Sep 11, 2023
Closed
2 tasks
@deyihu
Copy link
Contributor Author

deyihu commented Sep 12, 2023 •
edited

@microsoft-github-policy-service agree

@mjbvz mjbvz assigned alexdima and unassigned mjbvz Oct 5, 2023
@mjbvz mjbvz self-assigned this Jan 11, 2024
@mjbvz mjbvz added this to the December / January 2024 milestone Jan 11, 2024
@mjbvz mjbvz enabled auto-merge (squash) January 11, 2024 23:44
mjbvz
mjbvz previously approved these changes Jan 11, 2024
View reviewed changes
rebornix
rebornix previously approved these changes Jan 12, 2024
View reviewed changes
@mjbvz mjbvz dismissed stale reviews from rebornix and themself via e415f4b January 23, 2024 18:32
@aiday-mar aiday-mar modified the milestones: December / January 2024, February 2024 Jan 24, 2024
@rzhao271 rzhao271 mentioned this pull request Jan 24, 2024
Closed
@mjbvz mjbvz modified the milestones: February 2024, March 2024 Feb 21, 2024
mjbvz
mjbvz previously approved these changes Feb 26, 2024
View reviewed changes
mjbvz
mjbvz previously approved these changes Feb 26, 2024
View reviewed changes
joyceerhl
joyceerhl previously approved these changes Feb 27, 2024
View reviewed changes
@mjbvz mjbvz dismissed stale reviews from joyceerhl and themself via 276b74d February 27, 2024 19:01
@mjbvz
Copy link
Contributor

mjbvz commented Feb 27, 2024

@alexdima or @hediet Can you help with figure out where clipboardEvent?: ClipboardEvent; should live so that Monaco users can access it? Right now adding the references to ClipboardEvent in editorCommon causes a layer violation

@hediet
Copy link
Member

hediet commented Feb 28, 2024

Can you help with figure out where clipboardEvent?: ClipboardEvent; should live so that Monaco users can access it?

You could put it in src/vs/editor/browser/editorBrowser.ts.
I don't fully understand the purpose of src/vs/editor/common/editorCommon.ts though, but sending ClipboardEvent data through the common layer would break that abstraction.
Maybe instead of ClipboardEvent, a custom interface should be used that exposes just what is needed?

@mjbvz mjbvz merged commit 7caab31 into microsoft:main Mar 16, 2024
6 checks passed
@deyihu deyihu deleted the 192729 branch March 16, 2024 10:48
chen-ky pushed a commit to chen-ky/vscode that referenced this pull request Mar 18, 2024
@deyihu @mjbvz @chen-ky
editor paste event result return ClipboardEvent (microsoft#192732)
8b5b725 
* editor paste event result return ClipboardEvent

* Remove commented out code

* Cleanup `applyDefaultPasteHandler`

---------

Co-authored-by: Matt Bierner <matb@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

@alexdima alexdima alexdima approved these changes

@rebornix rebornix rebornix left review comments

@mjbvz mjbvz mjbvz left review comments

@joyceerhl joyceerhl joyceerhl left review comments

Assignees

@alexdima alexdima

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
March 2024
Development

Successfully merging this pull request may close these issues.

editor paste event result return ClipboardEvent
9 participants
@deyihu @mjbvz @hediet @rebornix @Tyriar @alexdima @joyceerhl @TylerLeonhardt @aiday-mar