Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💄 withTestNotebook tracks disposables internally. #192796

Merged
merged 2 commits into from
Sep 11, 2023
Merged

💄 withTestNotebook tracks disposables internally. #192796

merged 2 commits into from
Sep 11, 2023

Conversation

rebornix
Copy link
Member

We can use the disposable store exposed by withTestNotebook and keep everything tracked by the test itself.

@rebornix rebornix self-assigned this Sep 11, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the September 2023 milestone Sep 11, 2023
amunger
amunger previously approved these changes Sep 11, 2023
View reviewed changes
@rebornix rebornix merged commit ba3978f into main Sep 11, 2023
6 checks passed
@rebornix rebornix deleted the rebornix/abstract-nightingale branch September 11, 2023 17:15
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amunger amunger amunger approved these changes

Assignees

@rebornix rebornix

Labels
None yet
Projects
None yet
Milestone
September 2023
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rebornix @amunger @VSCodeTriageBot